Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use old small Workspace Image for VMs for now #8407

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Use old small Workspace Image for VMs for now #8407

merged 1 commit into from
Feb 23, 2022

Conversation

mads-hartmann
Copy link
Contributor

/werft with-vm=true

Description

We're currently experimenting with using image gitpod-k3s-202202151924-2 for VM-based preview environments, but are having problems getting them to work.

The current VM manifest is referencing a storage class that no longer exists. This PR switches back to use the storage class that uses the workspace image gitpod-k3s-202112202344.

While we don't want to go to beta with this image, we might as well use an image on main which works for now.

Related Issue(s)

No issue

How to test

Run a Werft job off this branch, the werft command above will have it use VMs. Verify that the VM boots and that you can get SSH access, kubectl access, and that workspaces (eventually) start.

Release Notes

NONE

Documentation

N/A

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #8407 (75e1d5b) into main (a87a1c8) will decrease coverage by 3.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8407      +/-   ##
==========================================
- Coverage   14.55%   11.17%   -3.38%     
==========================================
  Files          51       18      -33     
  Lines        4878      993    -3885     
==========================================
- Hits          710      111     -599     
+ Misses       4106      880    -3226     
+ Partials       62        2      -60     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/quota/size.go
components/ws-daemon/pkg/content/archive.go
install/installer/pkg/common/render.go
install/installer/pkg/common/storage.go
install/installer/pkg/common/display.go
.../installer/pkg/components/ws-manager/deployment.go
components/ws-daemon/pkg/daemon/markunmount.go
components/ws-daemon/pkg/content/tar.go
components/ws-daemon/pkg/cpulimit/dispatch.go
...components/ws-manager/unpriviledged-rolebinding.go
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87a1c8...75e1d5b. Read the comment docs.

@mads-hartmann
Copy link
Contributor Author

mads-hartmann commented Feb 23, 2022

/werft run

👍 started the job as gitpod-build-mads-small-vm.2

@mads-hartmann mads-hartmann marked this pull request as ready for review February 23, 2022 14:04
@mads-hartmann mads-hartmann requested a review from a team February 23, 2022 14:04
@roboquat roboquat merged commit 4a88603 into main Feb 23, 2022
@roboquat roboquat deleted the mads/small-vm branch February 23, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants