Deal with when cpu.cfs_quota_us is negative

[utam0k]

Description

Deal with when cpu.cfs_quota_us is negative

Related Issue(s)

None

How to test

$ cd /workspace/gitpod/components/ws-daemon
$ go test -v ./...

Release Notes

Deal with when cpu.cfs_quota_us is negative

Documentation

No

[codecov]

Codecov Report

Merging #8428 (78720fc) into main (343ae26) will decrease coverage by 17.91%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##             main    #8428       +/-   ##
===========================================
- Coverage   32.85%   14.94%   -17.92%     
===========================================
  Files          33       49       +16     
  Lines        4745     4732       -13     
===========================================
- Hits         1559      707      -852     
- Misses       3068     3955      +887     
+ Partials      118       70       -48     

Flag	Coverage Δ
components-gitpod-cli-app	11.17% <ø> (ø)
components-local-app-app-darwin-amd64	?
components-local-app-app-darwin-arm64	?
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
components-ws-daemon-app	21.17% <50.00%> (?)
components-ws-daemon-lib	21.17% <50.00%> (?)
components-ws-manager-app	?
install-installer-raw-app	4.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/ws-daemon/pkg/cpulimit/cfs.go	30.52% <50.00%> (ø)
components/ws-manager/pkg/manager/manager_ee.go
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go
...-manager/pkg/manager/internal/workpool/workpool.go
components/ws-manager/pkg/clock/clock.go
components/ws-manager/pkg/manager/metrics.go
...omponents/ws-manager/pkg/manager/pod_controller.go
components/ws-manager/pkg/manager/probe.go
components/ws-manager/pkg/manager/monitor.go
components/ws-manager/pkg/manager/annotations.go
... and 37 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343ae26...78720fc. Read the comment docs.

[utam0k]

I couldn't find any documentation where max has any meaning 🤔
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/resource_management_guide/sec-cpu

[kylos101]

Hey @utam0k ,

Thank you for your considerate PR! You rock. 😄

Is this happening in prod now? If yes, can you share a link to a log in GCP so I can inspect frequency?

What is the user experience like when it happens? I'm just curious.

PS: It's the weekend, no need to answer now, can do on Monday.

[kylos101]

As this has no issue, I added it to our project, and assigned you, @utam0k .

[utam0k]

Hey @utam0k ,

Thank you for your considerate PR! You rock. 😄

Is this happening in prod now? If yes, can you share a link to a log in GCP so I can inspect frequency?

What is the user experience like when it happens? I'm just curious.

PS: It's the weekend, no need to answer now, can do on Monday.

Hi @kylos101 I didn't create an issue because I thought it would be a quick fix, sorry.
Currently this is not an error, it is simply handled as an overflow. I have written a test and confirmed the situation with the debugging tools. It doesn't affect the user, because the overflow values can be compared with each other. I checked the kernel code, and it seems that all negative values represent infinity, but well, there is only -1 in effect. However, it's not very good and I want to fix it in this PR.

[utam0k]

@sagor999 Thanks for your review. I made some comments and a commitment to addressing your feedback. PTAL.