Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[server, db] AuthProviderEntry: Introduce oauthRevision to av…" #8431

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Feb 24, 2022

Reverts #8201

…oid repeated materialization of encrypted data"

This reverts the revert because our pipeline should now be able to handle it.

Description

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

…on to avoid repeated materialization of encrypted data""

This reverts commit ddc7aaa.
@geropl geropl requested a review from a team February 24, 2022 08:40
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team and removed size/XL labels Feb 24, 2022
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geropl
Copy link
Member Author

geropl commented Feb 24, 2022

/werft run

👍 started the job as gitpod-build-revert-8201-gpl-revert-7847.1

Re-try timed-out test

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #8431 (0d0df6c) into main (513cdae) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8431      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 513cdae...0d0df6c. Read the comment docs.

@roboquat roboquat merged commit 4e33131 into main Feb 24, 2022
@roboquat roboquat deleted the revert-8201-gpl/revert-7847 branch February 24, 2022 09:00
@AlexTugarev AlexTugarev mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants