Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stable with vscode_session telemetry fix #8444

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Feb 24, 2022

Description

Remove track event vscode_session phase running and end, see changes here gitpod-io/openvscode-server@a8cf2c0

Related Issue(s)

Related #8375

How to test

  1. Use vscode stable
  2. Open a workspace
  3. Open about dialog and check commit is gitpod-io/openvscode-server@55fa997

Release Notes

NONE

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #8444 (7fcd811) into main (6afc7f2) will decrease coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #8444      +/-   ##
========================================
- Coverage   8.41%   7.59%   -0.83%     
========================================
  Files         33      31       -2     
  Lines       2340    2172     -168     
========================================
- Hits         197     165      -32     
+ Misses      2138    2004     -134     
+ Partials       5       3       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
install-installer-raw-app 4.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afc7f2...7fcd811. Read the comment docs.

@jeanp413 jeanp413 marked this pull request as ready for review February 24, 2022 18:06
@jeanp413 jeanp413 requested a review from a team February 24, 2022 18:06
@jeanp413 jeanp413 requested a review from mustard-mh February 24, 2022 18:07
@roboquat roboquat merged commit b1c83db into main Feb 24, 2022
@roboquat roboquat deleted the jp/stable-vs-session branch February 24, 2022 18:08
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants