Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log workspace starts and stop #8461

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Log workspace starts and stop #8461

merged 1 commit into from
Feb 25, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Feb 25, 2022

Description

Logs workspace starts and stops which makes it easier to correlate log entries.

StartWorkspace

StopWorkspace

Related Issue(s)

Fixes #8449

How to test

  • Start workspace
  • Stop workspace
  • Check logs

Release Notes

NONE

@Furisto Furisto requested a review from a team February 25, 2022 15:55
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #8461 (ef1674d) into main (6afc7f2) will increase coverage by 2.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #8461      +/-   ##
=========================================
+ Coverage   8.41%   11.17%   +2.75%     
=========================================
  Files         33       18      -15     
  Lines       2340      993    -1347     
=========================================
- Hits         197      111      -86     
+ Misses      2138      880    -1258     
+ Partials       5        2       -3     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...staller/pkg/components/ws-manager/networkpolicy.go
...l/installer/pkg/components/ws-manager/configmap.go
...components/ws-manager/unpriviledged-rolebinding.go
...nstall/installer/pkg/components/ws-manager/role.go
install/installer/pkg/common/display.go
components/local-app/pkg/auth/pkce.go
install/installer/pkg/common/render.go
.../installer/pkg/components/ws-manager/deployment.go
install/installer/pkg/common/objects.go
install/installer/pkg/common/common.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afc7f2...ef1674d. Read the comment docs.

@roboquat roboquat merged commit db3371b into main Feb 25, 2022
@roboquat roboquat deleted the fo/8449-2 branch February 25, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-manager] log requests to start and stop workspaces
3 participants