-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[preview env] extend deny egress block #8476
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8476 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
CC @mrsimonemms I am not sure this will affect any GKE cluster or just our preview environment, if all GKE cluster affect, I think changing installer network policy is a better way |
@iQQBot I'm not sure of the underlying cause, but this looks to be ok. Looking through the code, we have this IP in twice
|
@mrsimonemms workspace and imagebuild both controlled by network policy |
@mrsimonemms can you use GKE start a gitpod cluster, and test it if it can access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test ok, approve to make preview env works
Description
From #8336 We added GCP metadata security detection to the Preview environment, so that if GCP metadata is accessible in the workspace, the supervisor will immediately end the process to prevent sensitive information from being leaked.
But if we only block 169.254.169.254, it still can access by HTTP request, I don't know why
Perhaps in GKE, this IP is special and may not be controlled by the network policy
After testing, I found that changing the blocked IP to 169.254.169.254/30 solves the problem, I don't know the exact reason, but it does work
I am not sure this will affect any GKE cluster or just our preview environment, if all GKE clusters affect, I think changing installer network policy is a better way
We have two ways to temporarily alleviate this problem
This PR use option 2
Related Issue(s)
Fixes #
How to test
Start a workspace, workspace can run
Release Notes
Documentation