Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: correct the stored config to include apiVersion #8527

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

The stored config was missing the apiVersion so was an invalid config. This also changes the format from JSON to YAML

This is useful when getting support bundles from KOTS so we can see the stored config to help with debugging

How to test

Deploy via the Installer and get the gitpod configmap

Release Notes

[installer]: correct the stored config to include apiVersion

Documentation

This also changes the format from JSON to YAML
@mrsimonemms mrsimonemms requested a review from a team March 2, 2022 09:34
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8527 (7731d8b) into main (05217c7) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8527      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05217c7...7731d8b. Read the comment docs.

@roboquat roboquat merged commit d46f49f into main Mar 2, 2022
@roboquat roboquat deleted the sje/install-config branch March 2, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants