Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to privacy policy from login page #8546

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Link to privacy policy from login page #8546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7a65c7
Link to privacy policy from login page
Mar 2, 2022
ff1ae72
Whitespace in login page footer
Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/dashboard/src/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export function Login() {
</div>
<div className="flex-none mx-auto h-20 text-center">
<span className="text-gray-400">
By signing in, you agree to our <a className="gp-link hover:text-gray-600" target="gitpod-terms" href="https://www.gitpod.io/terms/">terms of service</a>.
By signing in, you agree to our <a className="gp-link hover:text-gray-600" target="gitpod-terms" href="https://www.gitpod.io/terms/">terms of service</a> and <a className="gp-link hover:text-gray-600" target="gitpod-privacy" href="https://www.gitpod.io/privacy/">privacy policy</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Looks pretty straightforward and also wraps nicely on viewports with smaller width.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: We are using a similar notice about terms when installing Gitpod. Does it make sense to also include the privacy policy link there, too?

gitpod/components/dashboard/src/Setup.tsx

Line 48 in f56a9f2

By using Gitpod, you agree to our <a className="gp-link" target="gitpod-terms" href="https://www.gitpod.io/self-hosted-terms/">terms</a>.

Cc @corneliusludmann because of a relevant discussion.

Cc @mrsimonemms because of #7732 and in case we could drop the privacy link from the telemetry settings in the admin dashboard added in #7732 (review).

Cc @lucasvaltl @gitpod-io/engineering-self-hosted

</span>
</div>
</div>
Expand Down