Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] codehelper exec replace process #8552

Merged
merged 1 commit into from
Mar 2, 2022
Merged

[code] codehelper exec replace process #8552

merged 1 commit into from
Mar 2, 2022

Conversation

mustard-mh
Copy link
Contributor

Description

Use syscall.Exec to improve process tree

Related Issue(s)

Fixes #

How to test

  1. Use insider
  2. Start a workspace
  3. Run ps -efj fww, /ide/bin/gitpod-code must be direct children of supervisor
root           1       0       0       0  0 20:01 ?        Sl     0:00 supervisor init
root          26       1       0       0  0 20:01 ?        Sl     0:00 supervisor run
gitpod        47      26      47       0  0 20:01 ?        S      0:00  \_ sh /ide/bin/gitpod-code --start-server --install-builtin-extension github.vscode-pull-request-github --install-extension svelte.svelte-vscode --port 23000 --host 0.0.0.0 --without-connection-token --server-data-dir /workspace/.vscode-remote --do-not-sync

(We can remove this gitpod-code process too if we add exec to /ide/bin/gitpod-code. Or it's not necessary?)

Release Notes

NONE

Documentation

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8552 (570c5e2) into main (7ac5d9d) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8552      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-ide-code-codehelper-app ∅ <ø> (?)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac5d9d...570c5e2. Read the comment docs.

@jeanp413 jeanp413 self-requested a review March 2, 2022 20:18
@jeanp413
Copy link
Member

jeanp413 commented Mar 2, 2022

We can remove this gitpod-code process too if we add exec to /ide/bin/gitpod-code. Or it's not necessary?

It's fine, gitpod-code is generated when we build vscode from this file (it gets renamed inside the gulp task)

@roboquat roboquat merged commit 217ac59 into main Mar 2, 2022
@roboquat roboquat deleted the hw/code-exec branch March 2, 2022 20:43
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants