Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UA logo #8570

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Update UA logo #8570

merged 1 commit into from
Mar 3, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Mar 3, 2022

Description

Follow up from #8478. See also relevant discussion (internal).

Release Notes

NONE

@gtsiolis gtsiolis requested a review from a team March 3, 2022 15:06
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 3, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏
image

@roboquat roboquat merged commit e931577 into main Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #8570 (5f7e6fe) into main (89105f8) will decrease coverage by 17.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8570       +/-   ##
===========================================
- Coverage   28.99%   11.17%   -17.82%     
===========================================
  Files         150       18      -132     
  Lines       23101      993    -22108     
===========================================
- Hits         6698      111     -6587     
+ Misses      15794      880    -14914     
+ Partials      609        2      -607     
Flag Coverage Δ
components-blobserve-app ?
components-blobserve-lib ?
components-common-go-lib ?
components-content-service-api-go-lib ?
components-content-service-app ?
components-content-service-lib ?
components-ee-agent-smith-app ?
components-ee-agent-smith-lib ?
components-ee-kedge-app ?
components-gitpod-cli-app 11.17% <ø> (ø)
components-ide-code-codehelper-app ?
components-ide-jetbrains-cli-app ?
components-ide-jetbrains-image-status-app ?
components-image-builder-api-go-lib ?
components-image-builder-bob-app ?
components-image-builder-bob-runc-facade ?
components-image-builder-mk3-app ?
components-installation-telemetry-app ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-openvsx-proxy-app ?
components-openvsx-proxy-lib ?
components-registry-facade-app ?
components-registry-facade-lib ?
components-service-waiter-app ?
components-supervisor-app ?
components-workspacekit-app ?
components-ws-daemon-api-go-lib ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
components-ws-daemon-nsinsider-app ?
components-ws-manager-api-go-lib ?
components-ws-manager-app ?
components-ws-manager-bridge-api-go-lib ?
components-ws-proxy-app ?
dev-blowtorch-app ?
dev-loadgen-app ?
dev-poolkeeper-app ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/quota/size.go
components/ws-manager/pkg/manager/probe.go
components/common-go/log/export.go
components/ee/kedge/pkg/kedge/serve.go
components/ws-manager/pkg/manager/status.go
...nstall/installer/pkg/components/ws-manager/role.go
...omponents/registry-facade/pkg/registry/registry.go
components/content-service/pkg/layer/provider.go
components/workspacekit/cmd/rings.go
components/supervisor/pkg/supervisor/services.go
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89105f8...5f7e6fe. Read the comment docs.

@roboquat roboquat deleted the gt/update-ua-logo branch March 3, 2022 15:11
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me, thanks @gtsiolis!

Out of curiosity, how did you pick the colors?

  • I notice that you use #005BBB and #FFD500
  • Wikipedia seems to indicate #0057b7 (web-safe #0066cc) and #ffd700 (web-safe #ffcc00) as the official colors. Maybe the web-safe colors could make sense? 💭

@chrifro
Copy link

chrifro commented Mar 3, 2022

Just noticed that the cut between the colors isn't totally straight
Bildschirmfoto 2022-03-03 um 16 17 07

@gtsiolis gtsiolis mentioned this pull request Mar 3, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 3, 2022

Thanks @ChristinFrohne for noticing, @jankeromnes for caring about accessibility, and @geropl for taking a look! Opened a follow up PR in #8571 to straighten the line, use simpler SVG shapes, and use accessible colors as mentioned in #8570 (review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants