Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning when all attempts to download OTS have failed #8587

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented Mar 3, 2022

Description

add warning when all attempts to download OTS have failed.
To help distinguish failed attempt and when all attempts have failed.
See this: #8096 (comment)

Related Issue(s)

Fixes #

How to test

Release Notes

none

Documentation

Copy link
Member

@aledbf aledbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #8587 (373db4f) into main (ede9db9) will increase coverage by 17.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8587       +/-   ##
===========================================
+ Coverage   12.31%   29.59%   +17.27%     
===========================================
  Files          20      111       +91     
  Lines        1161    18008    +16847     
===========================================
+ Hits          143     5329     +5186     
- Misses       1014    12219    +11205     
- Partials        4      460      +456     
Flag Coverage Δ
components-content-service-app 14.19% <0.00%> (?)
components-content-service-lib 14.19% <0.00%> (?)
components-gitpod-cli-app 11.17% <ø> (ø)
components-image-builder-mk3-app 35.71% <ø> (?)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app 35.43% <ø> (?)
components-ws-daemon-app 21.17% <ø> (?)
components-ws-daemon-lib 21.17% <ø> (?)
components-ws-manager-app 39.44% <ø> (?)
components-ws-proxy-app 68.63% <ø> (?)
install-installer-raw-app 4.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/content-service/pkg/initializer/initializer.go 6.97% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/ws-manager/pkg/manager/probe.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 20.28% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
components/ws-manager/pkg/manager/annotations.go 68.42% <0.00%> (ø)
components/ws-proxy/pkg/proxy/workspacerouter.go 81.89% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 33.33% <0.00%> (ø)
components/ws-daemon/pkg/cpulimit/cpulimit.go 68.83% <0.00%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede9db9...373db4f. Read the comment docs.

@roboquat roboquat merged commit 3063396 into main Mar 4, 2022
@roboquat roboquat deleted the pavel/ots branch March 4, 2022 00:06
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants