Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): add github app install script for dev iteration against staging github app #8591

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Mar 4, 2022

Description

Moves the script from internal documentation into the repository for ease of use. This is needed to be able to iterate on github app integration locally/in dev.

Related Issue(s)

How to test

Release Notes

NONE

Documentation

@easyCZ easyCZ requested a review from a team March 4, 2022 07:58
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #8591 (ea874f2) into main (3063396) will decrease coverage by 18.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8591       +/-   ##
===========================================
- Coverage   29.53%   11.17%   -18.36%     
===========================================
  Files         113       18       -95     
  Lines       18177      993    -17184     
===========================================
- Hits         5369      111     -5258     
+ Misses      12349      880    -11469     
+ Partials      459        2      -457     
Flag Coverage Δ
components-content-service-app ?
components-content-service-lib ?
components-gitpod-cli-app 11.17% <ø> (ø)
components-image-builder-mk3-app ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
components-ws-manager-app ?
components-ws-proxy-app ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/content/tar.go
components/ws-manager/pkg/manager/manager_ee.go
components/ws-manager/pkg/manager/probe.go
components/ws-daemon/pkg/content/archive.go
components/supervisor/pkg/terminal/ring-buffer.go
components/ws-manager/pkg/manager/annotations.go
components/ws-proxy/pkg/proxy/pass.go
components/content-service/pkg/storage/storage.go
components/content-service/pkg/storage/gcloud.go
...s/content-service/pkg/service/ideplugin-service.go
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3063396...ea874f2. Read the comment docs.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 4284d72 into main Mar 4, 2022
@roboquat roboquat deleted the mp/add-gh-install branch March 4, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants