Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to vscode 1.65 #8609

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Update to vscode 1.65 #8609

merged 1 commit into from
Mar 4, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Mar 4, 2022

Description

Update code to 1.65.

How to test

  • Switch to VS Code Insiders in settings.
  • Start a workspace.
  • Test following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data are sync across workspaces as well as on workspace restart, especially for extensions
    • extensions from .gitpod.yml are not installed as sync
    • extensions installed as sync are actually sync in new workspaces
    • settings should not contain any mentions of MS telemetry
    • websockets and workers are properly proxied
      • diff editor should be operatable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old websockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod prefix
    • that a PR view is preloaded on the PR url
    • test gp open and preview
    • test open in VS Code Desktop, check gp open and preview in task/user terminals
    • telemetry data is collected in Segment

Release Notes

NONE

/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe
/werft no-preview

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Mar 4, 2022

/werft run

👍 started the job as gitpod-build-hw-gp-s-rls.1

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #8609 (3d94ffb) into main (3b07473) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8609      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b07473...3d94ffb. Read the comment docs.

@jeanp413
Copy link
Member

jeanp413 commented Mar 4, 2022

/werft with-clean-slate-deployment with-helm

👎 unknown command: with-clean-slate-deployment
Use /werft help to list the available commands

@jeanp413
Copy link
Member

jeanp413 commented Mar 4, 2022

/werft run with-clean-slate-deployment with-helm

👍 started the job as gitpod-build-hw-gp-s-rls.2

@jeanp413 jeanp413 marked this pull request as ready for review March 4, 2022 19:55
@jeanp413 jeanp413 self-requested a review March 4, 2022 19:55
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Mar 4, 2022

/werft run no-preview

👍 started the job as gitpod-build-hw-gp-s-rls.3

jeanp413
jeanp413 previously approved these changes Mar 4, 2022
@iQQBot
Copy link
Contributor

iQQBot commented Mar 4, 2022

/hold

@jeanp413
Copy link
Member

jeanp413 commented Mar 4, 2022

Thanks @iQQBot I forgot to update the commit message

@iQQBot
Copy link
Contributor

iQQBot commented Mar 4, 2022

/unhold

@jeanp413 jeanp413 self-requested a review March 4, 2022 20:04
Copy link
Member

@jeanp413 jeanp413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/werft run no-preview

@roboquat roboquat merged commit 177baa6 into main Mar 4, 2022
@roboquat roboquat deleted the hw/gp-s-rls branch March 4, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants