Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] fix typos in READMEs #8642

Merged
merged 1 commit into from
Mar 7, 2022
Merged

[readme] fix typos in READMEs #8642

merged 1 commit into from
Mar 7, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

Fixes some typos and wrong wordings in main and installer READMEs

Related Issue(s)

NA

How to test

NA

Release Notes

NONE

Documentation

No

@nandajavarma nandajavarma requested a review from a team March 7, 2022 14:55
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #8642 (9d74f32) into main (840d29a) will increase coverage by 3.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #8642      +/-   ##
=========================================
+ Coverage   8.15%   11.17%   +3.01%     
=========================================
  Files         34       18      -16     
  Lines       2402      993    -1409     
=========================================
- Hits         196      111      -85     
+ Misses      2201      880    -1321     
+ Partials       5        2       -3     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...installer/pkg/components/ws-manager/rolebinding.go
install/installer/pkg/common/networkpolicies.go
install/installer/pkg/common/display.go
install/installer/pkg/common/ca.go
install/installer/pkg/common/common.go
install/installer/pkg/common/storage.go
...l/installer/pkg/components/ws-manager/tlssecret.go
components/local-app/pkg/auth/pkce.go
install/installer/pkg/common/objects.go
components/local-app/pkg/auth/auth.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 840d29a...9d74f32. Read the comment docs.

Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Gitpod

@mrsimonemms
Copy link
Contributor

/lgtm

@roboquat roboquat merged commit ede4b47 into main Mar 7, 2022
@roboquat roboquat deleted the nvn/readme-typo branch March 7, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants