[kots]: add workaround for #8529 #8657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go library has a misconfiguration which adds in "replicas" and "availableReplicas" to the OpenVSX Proxy StatefulSet. This can cause validation issues dependent upon the version of Kubernetes that's being used. This removes the block from the rendered Kubernetes objects which is the expected behaviour.
mrsimonemms
force-pushed
the
sje/kots-statefulset
branch
from
e6b56e7 to
fdf1358
Compare
Codecov Report
@@ Coverage Diff @@
## main #8657 +/- ##
==========================================
- Coverage 14.56% 11.17% -3.39%
==========================================
Files 53 18 -35
Lines 5067 993 -4074
==========================================
- Hits 738 111 -627
+ Misses 4257 880 -3377
+ Partials 72 2 -70
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
corneliusludmann
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workaround for #8529, using the advice of #8532
The Go library has a misconfiguration which adds in
replicasandavailableReplicasto the OpenVSX Proxy StatefulSet. This can cause validation issues dependent upon the version of Kubernetes that's being used.This removes the block from the rendered Kubernetes objects which is the expected behaviour.
How to test
Run via KOTS
Release Notes
Documentation