Skip to content

Enable changing default editor in integration tests #8666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Mar 8, 2022

Description

Enable changing default editor in integration tests

Related Issue(s)

related #3065

How to test

  1. Open preview environment and login
  2. In workspace cd ./test/tests/ide/
  3. Run export USER_TOKEN=foo
  4. Run test manually go test -v github.com/gitpod-io/gitpod/test/tests/ide/vscode -kubeconfig=/home/gitpod/.kube/config -namespace=staging-jp-set-editor-test -username=<username>
  5. Open prev env dashboard and see you default ide is vscode insiders

Release Notes

NONE

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #8666 (a169fb6) into main (7dd98f8) will not change coverage.
The diff coverage is n/a.

❗ Current head a169fb6 differs from pull request most recent head 35bff75. Consider uploading reports for the commit 35bff75 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8666   +/-   ##
=======================================
  Coverage   11.17%   11.17%           
=======================================
  Files          18       18           
  Lines         993      993           
=======================================
  Hits          111      111           
  Misses        880      880           
  Partials        2        2           
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd98f8...35bff75. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@jeanp413 jeanp413 force-pushed the jp/set-editor-test branch from a169fb6 to 35bff75 Compare March 8, 2022 15:53
@jeanp413 jeanp413 marked this pull request as ready for review March 8, 2022 16:27
@jeanp413 jeanp413 requested a review from a team March 8, 2022 16:27
@jeanp413 jeanp413 requested a review from iQQBot March 8, 2022 16:27
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 8, 2022
@laushinka
Copy link
Contributor

Worked as advertised.

LGTM

@roboquat roboquat merged commit 95a4382 into main Mar 9, 2022
@roboquat roboquat deleted the jp/set-editor-test branch March 9, 2022 11:22
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants