Skip to content

Send slack notification when IDE integration tests fails #8673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Mar 8, 2022

Description

Send slack notification when IDE integration tests fails

Related Issue(s)

related #3065

How to test

Test notification here https://gitpod.slack.com/archives/C02F9LQU4DR/p1646790101584589

Release Notes

NONE

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #8673 (515d9e4) into main (7dd98f8) will not change coverage.
The diff coverage is n/a.

❗ Current head 515d9e4 differs from pull request most recent head 04a783b. Consider uploading reports for the commit 04a783b to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8673   +/-   ##
=======================================
  Coverage   11.17%   11.17%           
=======================================
  Files          18       18           
  Lines         993      993           
=======================================
  Hits          111      111           
  Misses        880      880           
  Partials        2        2           
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd98f8...04a783b. Read the comment docs.

@jeanp413 jeanp413 force-pushed the jp/ide-test-slack branch from d088f4f to 6a01db0 Compare March 8, 2022 20:04
@roboquat roboquat added size/S and removed size/L labels Mar 9, 2022
@jeanp413 jeanp413 force-pushed the jp/ide-test-slack branch from 515d9e4 to 04a783b Compare March 9, 2022 01:55
@jeanp413 jeanp413 requested a review from iQQBot March 9, 2022 01:58
@jeanp413 jeanp413 marked this pull request as ready for review March 9, 2022 01:58
command:
- /bin/bash
- -c
- |
sleep 1
set -Eeuo pipefail

printf '{{ toJson .Annotations }}' > context.json
printf '{{ toJson . }}' > context.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this broken JetBrains integration, but will fix in next PR

-H 'Content-type: application/json' \
-d "{\"blocks\":[{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"${title}\"},\"accessory\":{\"type\":\"button\",\"text\":{\"type\":\"plain_text\",\"text\":\"Go to Werft\",\"emoji\":true},\"value\":\"click_me_123\",\"url\":\"${werftJobUrl}\",\"action_id\":\"button-action\"}},{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"\`\`\`\\n${body}\\n\`\`\`\"}}]}" \
"https://hooks.slack.com/${SLACK_NOTIFICATION_PATH}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also send a notification of success?

@iQQBot
Copy link
Contributor

iQQBot commented Mar 9, 2022

/hold

@iQQBot
Copy link
Contributor

iQQBot commented Mar 9, 2022

/unhold
I think this can be merged first and then further processed in a subsequent PR

@roboquat roboquat merged commit af79008 into main Mar 9, 2022
@roboquat roboquat deleted the jp/ide-test-slack branch March 9, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants