Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics] Enrich 'workspace_started' call with projectId and type #8794

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

jakobhero
Copy link
Contributor

@jakobhero jakobhero commented Mar 14, 2022

Description

Augments the workspace_started event call with projectId, type, context, and config.

How to test

  1. Open a preview environment, sign up and start a workspace
  2. Go to the debugger of Staging Untrusted
    and ensure the workspace_started event is delivered, including the new properties projectId, type, context, and config

Release Notes

NONE

Documentation

/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@jakobhero jakobhero changed the title Enrich 'workspace_started' call with projectId, type, context, and config [Analytics] Enrich 'workspace_started' call with projectId, type, context, and config Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #8794 (40e455d) into main (55b3ec2) will not change coverage.
The diff coverage is n/a.

❗ Current head 40e455d differs from pull request most recent head d9b8906. Consider uploading reports for the commit d9b8906 to get more accurate results

@@           Coverage Diff           @@
##             main    #8794   +/-   ##
=======================================
  Coverage   11.17%   11.17%           
=======================================
  Files          18       18           
  Lines         993      993           
=======================================
  Hits          111      111           
  Misses        880      880           
  Partials        2        2           
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jakobhero jakobhero force-pushed the jh/track-ws-enriched branch from 40e455d to e472192 Compare March 14, 2022 14:09
@jakobhero jakobhero changed the title [Analytics] Enrich 'workspace_started' call with projectId, type, context, and config [Analytics] Enrich 'workspace_started' call with projectId and type Mar 14, 2022
@jakobhero jakobhero marked this pull request as ready for review March 14, 2022 14:10
@jakobhero jakobhero requested a review from a team March 14, 2022 14:10
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 14, 2022
secretdude304
secretdude304 previously approved these changes Mar 23, 2022
@easyCZ
Copy link
Member

easyCZ commented Mar 28, 2022

Hey, thanks for raising. Looks like this needs a rebase.

@jakobhero
Copy link
Contributor Author

Hey, thanks for raising. Looks like this needs a rebase.

thanks for letting me know, it's rebased now!

@roboquat roboquat merged commit a99af87 into main Mar 28, 2022
@roboquat roboquat deleted the jh/track-ws-enriched branch March 28, 2022 12:13
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants