Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jb-gw]: add workspace branch & creation timespan column for workspace panel #8940

Merged
merged 1 commit into from
Mar 31, 2022
Merged

[jb-gw]: add workspace branch & creation timespan column for workspace panel #8940

merged 1 commit into from
Mar 31, 2022

Conversation

yaohui-wyh
Copy link
Contributor

@yaohui-wyh yaohui-wyh commented Mar 23, 2022 •
edited by iQQBot
Loading

Description

This PR relates to Gitpod's JetBrains Gateway plugin, which enables IntelliJ IDEs users to create or start a Gitpod workspace using desktop IDE client. The plugin is a great starting point for developers familiarized with local IntelliJ IDEs to try Gitpod remote development with JB Gateway.

However the workspace panel of JB-GW plugin lacks information such as workspace branch & creation time:
image

Compared with Gitpod's WebUI:
image

This PR adds workspace branch & creation timespan column:
image

How to test

Build & Install the plugin following
https://github.com/gitpod-io/gitpod/blob/main/components/ide/jetbrains/gateway-plugin/README.md#L8

Release Notes

Add workspace branch & creation timespan column for Gitpod Jetbrains Gateway plugin workspace panel

@yaohui-wyh yaohui-wyh requested a review from a team March 23, 2022 14:06
@iQQBot iQQBot added the do-not-merge/cla-pending CLA has not been signed label Mar 23, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 28, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks for contributing, @yaohui-wyh! 🍊

You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓

felladrin
felladrin reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
This looks great!

image

...jetbrains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodWorkspacesView.kt Outdated Show resolved Hide resolved
Sunset17
Sunset17 reviewed Mar 28, 2022
View reviewed changes
Copy link

@Sunset17 Sunset17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help me with this

@yaohui-wyh
Copy link
Contributor Author

@meysholdt Could you send me a CLA link? Thanks

@meysholdt
Copy link
Member

Hi @yaohui-wyh! I've sent you the CLA via email/DocuSign. regards, Moritz

@yaohui-wyh
Copy link
Contributor Author

Hi @yaohui-wyh! I've sent you the CLA via email/DocuSign. regards, Moritz

Thanks @meysholdt I signed it

@felladrin
Copy link
Contributor

Thanks @yaohui-wyh!
If it's not asking too much, could you squash your commits and rebase it onto main branch?
Then we're all settled for merging it.

@yaohui-wyh
Copy link
Contributor Author

Thanks @yaohui-wyh! If it's not asking too much, could you squash your commits and rebase it onto main branch? Then we're all settled for merging it.

Sure, no problem. Done

@iQQBot
Copy link
Contributor

iQQBot commented Mar 31, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@meysholdt Can you please check the CLA status? 🙏

@meysholdt meysholdt added cla: accepted ✔️ and removed do-not-merge/cla-pending CLA has not been signed labels Mar 31, 2022
@meysholdt
Copy link
Member

I can confirm that the CLA is signed. Thank you, @yaohui-wyh!

iQQBot
iQQBot previously approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaohui-wyh Thank you for your contribution!

@iQQBot
Copy link
Contributor

iQQBot commented Mar 31, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-main-fork.22

@iQQBot
Copy link
Contributor

iQQBot commented Mar 31, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@yaohui-wyh build was failed...bacause some license headers missing.
You can run leeway run components:update-license-header then rebase and commit again. Thank you very much! 🙏

@yaohui-wyh
Copy link
Contributor Author

yaohui-wyh commented Mar 31, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👎 not authorized

@iQQBot
Copy link
Contributor

iQQBot commented Mar 31, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-main-fork.23

@mustard-mh
Copy link
Contributor

mustard-mh commented Mar 31, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-main-fork.24

@roboquat roboquat merged commit 83e3ef6 into gitpod-io:main Mar 31, 2022
@akosyakov
Copy link
Member

akosyakov commented Mar 31, 2022 •
edited
Loading

@felladrin Will you release it in stable channel?

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Mar 31, 2022
@felladrin
Copy link
Contributor

Plugin updated on the Marketplace!
https://plugins.jetbrains.com/plugin/18438-gitpod-gateway

Two versions were published, one to cover JetBrains Gateway Stable and another for EAP.

Users can update it by opening JetBrains Gateway Preferences >> Plugins.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felladrin felladrin felladrin left review comments

@Sunset17 Sunset17 Sunset17 left review comments

@iQQBot iQQBot iQQBot approved these changes

Assignees
No one assigned
Labels
cla: accepted ✔️ community-contribution deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/L team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@yaohui-wyh @gtsiolis @meysholdt @felladrin @iQQBot @mustard-mh @akosyakov @Sunset17 @roboquat