Ignore VNC related ports on boot #8993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
previously approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Awesome improvement, thanks @mads-hartmann! 👏
Small nit: I'd love the ports to be specified in ascending order (especially since we're beginning to have lots of them)
Adding a hold in case you'd like to address this:
/hold
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you open a new workspace for gitpod-io/gitpod you'll get two little popups about open ports. Given that we always start these services I added them to the gitpod.yaml and marked them as "ignored" so we won't get popups for them anymore.
Related Issue(s)
No issue
How to test
If you opened a workspace before you would get the following:
On this branch you'll get:
Release Notes
Documentation
N/A