Skip to content

ui: enlarge search box on dashboard #8994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jankeromnes
Copy link
Contributor

Restored @tnir's excellent community contribution from #8813 post revert

Description

Enlarges the search box on dashboard.

See the (simplified) sample code:

https://codepen.io/tnir/pen/GRyJoRE

Related Issue(s)

Fixes #8812 (part of #3727)

Improves #3295

How to test

Prepare an environment and resize the window size responsively.

Release Notes

NONE

(or Enlarge search box on dashboard)

Documentation

No.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Mar 29, 2022

@easyCZ Could you please approve these changes again?

Note: There is now a hold on this Pull Request while we figure out the CLA thing. 🧘

@easyCZ
Copy link
Member

easyCZ commented Mar 29, 2022

I believe there still remains the regression outlined in #8969 (review). I'm watching this PR so will TAL whenever that is resolved.

@gtsiolis gtsiolis marked this pull request as draft March 29, 2022 11:26
@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 29, 2022

fyi: Converted this to draft PR until when the UX regression issues described in #8994 (comment) have been resolved and this is ready for review.

@tnir
Copy link
Contributor

tnir commented Mar 31, 2022

Signing CLA looks taking longer than expected. It took 13 days just to get the form and there looks like a problem in #7864 so it would take 1 month or so. Before finishing to sign CLA, I would like not to update the changes.

@jankeromnes Close this PR as I cannot update the changes as this PR in @gitpod-io.

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Mar 31, 2022

Sorry for being silly and slow with the CLA 😞 I hope we can do better, because contributor free time and energy are extremely precious and rare. ❤️

Closing this PR as requested. Please re-send a PR once the CLA situation is sorted, and please ping me if I can do anything at all to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants