Skip to content

[wip][dashboard] license tab in the admin dashboard #9031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[wip][dashboard] license tab in the admin dashboard #9031

wants to merge 2 commits into from

Conversation

nandajavarma
Copy link
Contributor

Description

This PR adds a License tab in the admin dashboard listing relevant information about the associated license

Related Issue(s)

Fixes #8413

How to test

Release Notes

Documentation

@nandajavarma nandajavarma requested a review from a team March 30, 2022 21:59
@roboquat
Copy link
Contributor

@nandajavarma: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nandajavarma nandajavarma marked this pull request as draft March 30, 2022 21:59
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 30, 2022
@roboquat roboquat added size/L and removed size/XL labels Mar 30, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 4, 2022

/werft run

@nandajavarma
Copy link
Contributor Author

nandajavarma commented Apr 4, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate

👍 started the job as gitpod-build-nvn-license-dash.64

@nandajavarma nandajavarma force-pushed the nvn/license-dash branch 2 times, most recently from 313c12d to 49337cc Compare April 5, 2022 11:45
@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 5, 2022 •
edited
Loading

Hello @nandajavarma! Many thanks for working on this. 🙏 😊

I notice that this Pull Request has a review request to Team WebApp, but it is also marked as Draft and its title says "[wip]", so our team is currently ignoring the review signal. I'll temporarily remove the review request, but please do feel free to request a review again when the Pull Request is no longer [wip] / a Draft. 🚀

EDIT: Ha, sorry for the noise -- turns out that review requests to owners are mandatory in GitHub, and cannot be removed (even if in Draft). 😅 This is perfect as it is then. ✨

@nandajavarma nandajavarma mentioned this pull request Apr 7, 2022
Closed
2 tasks
@roboquat roboquat added size/XL and removed size/L labels Apr 12, 2022
@nandajavarma nandajavarma force-pushed the nvn/license-dash branch 10 times, most recently from b9e3ccd to 0f21ee4 Compare April 12, 2022 15:49
@nandajavarma nandajavarma force-pushed the nvn/license-dash branch 3 times, most recently from 40e107f to 04b6113 Compare April 13, 2022 15:06
@roboquat roboquat added size/XXL and removed size/XL labels Apr 13, 2022
@roboquat roboquat added size/XL and removed size/XXL labels Apr 14, 2022
@roboquat roboquat added size/XXL and removed size/XL labels Apr 14, 2022
@nandajavarma nandajavarma force-pushed the nvn/license-dash branch 2 times, most recently from a3bea7c to fb6c175 Compare April 14, 2022 10:17
@nandajavarma
Copy link
Contributor Author

nandajavarma commented Apr 14, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate

👍 started the job as gitpod-build-nvn-license-dash.114

@roboquat roboquat added size/XL and removed size/XXL labels Apr 14, 2022
@nandajavarma
Copy link
Contributor Author

nandajavarma commented Apr 14, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate

👍 started the job as gitpod-build-nvn-license-dash.117

@nandajavarma nandajavarma force-pushed the nvn/license-dash branch 5 times, most recently from 16ca8a7 to b965c16 Compare April 14, 2022 19:56
@nandajavarma
Copy link
Contributor Author

Closing this PR to open a clean one!

@nandajavarma nandajavarma deleted the nvn/license-dash branch April 14, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/release-note-label-needed do-not-merge/work-in-progress size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[licensing] Add a license page to the admin dashboard
4 participants
@nandajavarma @roboquat @gtsiolis @jankeromnes