Properly declare analytics variable #9047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run |
|
/werft run 👍 started the job as gitpod-build-as-fix-analytics.5 |
|
Tagging Huiwen and Filip just for awareness :) |
fullmetalrooster
previously approved these changes
Mar 31, 2022
|
/hold werft seems to be having problems connection to the pods? 🤔 |
ArthurSens
force-pushed
the
as/fix-analytics
branch
from
f11b057 to
7cdcb35
Compare
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
ArthurSens
force-pushed
the
as/fix-analytics
branch
from
7cdcb35 to
b71f190
Compare
|
/werft run analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe 👍 started the job as gitpod-build-as-fix-analytics.9 |
|
Not sure why this PR is not in tide's queue 🤔 |
|
@ArthurSens there's still the do-not-merge/hold label 👀 |
🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small fix for a bug introduced in #8884 and identified at #9044
Release Notes