Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9065: Blobserve does not launch in preview envs due to syntax er… #9066

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

meysholdt
Copy link
Member

Description

Blobserve does not launch in preview envs due to syntax error in JSON config

Related Issue(s)

Fixes # #9065

How to test

  1. run werft run github -a with-helm on this branch
  2. in the preview env, see that the pod blobserve enters state running. Without this fix, the pod is crash-looping.

Release Notes

NONE

Documentation

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mo!

@meysholdt
Copy link
Member Author

you're welcome!

@meysholdt
Copy link
Member Author

meysholdt commented Apr 1, 2022

/werft run

👍 started the job as gitpod-build-me-helm.6

@meysholdt
Copy link
Member Author

meysholdt commented Apr 1, 2022

/werft run no-preview=true

👍 started the job as gitpod-build-me-helm.7

Previews via Helm are still broken due to #8829.

@roboquat roboquat merged commit 003f9a3 into main Apr 1, 2022
@roboquat roboquat deleted the me/helm branch April 1, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants