Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "publish-to-kots" flag in werft #9070

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Add "publish-to-kots" flag in werft #9070

merged 1 commit into from
Apr 1, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

Add a publish-to-kots=true to Werft. This makes the publish to KOTS only happen when requested or on the main branch

How to test

Release Notes

NONE

Documentation

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Apr 1, 2022

/werft run publish-to-kots=true

👍 started the job as gitpod-build-sje-publish-to-kots.1

@mrsimonemms mrsimonemms force-pushed the sje/publish-to-kots branch from e3c06f2 to 3327165 Compare April 1, 2022 13:20
@roboquat roboquat added size/XS and removed size/M labels Apr 1, 2022
@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Apr 1, 2022

/werft run publish-to-kots=true

👍 started the job as gitpod-build-sje-publish-to-kots.3

@mrsimonemms mrsimonemms force-pushed the sje/publish-to-kots branch from 3327165 to 1ddbef9 Compare April 1, 2022 13:26
@mrsimonemms mrsimonemms marked this pull request as ready for review April 1, 2022 13:26
@meysholdt meysholdt self-requested a review April 1, 2022 13:27
@roboquat roboquat merged commit b30b4e4 into main Apr 1, 2022
@roboquat roboquat deleted the sje/publish-to-kots branch April 1, 2022 13:30
@ArthurSens
Copy link
Contributor

ArthurSens commented Apr 1, 2022

👋 coming for a late review 😅

Does it make sense to move publish-to-kots to be a method under buildAndPublish?

I'm thinking of keeping built.ts as small as possible, while putting logic where it makes sense 🙂 (I can create an issue for that if that's agreed

cc @gitpod-io/platform

@mrsimonemms
Copy link
Contributor Author

Yeah, I'm happy with that as a proposed change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants