Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots]: add a kernel version check to the preflights #9083

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

mrsimonemms
Copy link
Contributor

Description

Add a preflight check to ensure that the kernel version is 5.4.0 or above. It includes preflight checks, so that 5.4.0-gke would return as valid.

Related Issue(s)

Fixes #8862

How to test

Deploy via KOTS.

To check the functionality, run some of the followings:

docker run --rm alpine/semver semver --coerce --range '>=5.4.0' 5.13.0-1019-gcp // valid
docker run --rm alpine/semver semver --coerce --range '>=5.4.0' 5.4.0-1009-gcp // valid
docker run --rm alpine/semver semver --coerce --range '>=5.4.0' 5.3.9-1009-gcp // errors - would return "invalid"

Release Notes

[kots]: add a kernel version check to the preflights

Documentation

@mrsimonemms mrsimonemms requested a review from a team April 1, 2022 17:35
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Apr 1, 2022
@mrsimonemms
Copy link
Contributor Author

As a follow-up, have checked with Barry @ Replicated whether this image will automagically get added to the list of airgapped images or whether we need to add it to additionalImages list in kots-app.yaml

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@roboquat roboquat merged commit 88dd9c3 into main Apr 5, 2022
@roboquat roboquat deleted the sje/kots-kernel branch April 5, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel version
3 participants