Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitbucket-server] reuse icon from bitbucket #9099

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[bitbucket-server] reuse icon from bitbucket #9099

merged 1 commit into from
Apr 4, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Apr 4, 2022

A quick fix for the login page.

fixes #8603

NONE

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 4, 2022

Looking at this now once the build is finished! 👀

@gtsiolis gtsiolis requested a review from a team April 4, 2022 09:46
Comment on lines +20 to +21
case "BitbucketServer":
return <img className="fill-current filter-grayscale w-5 h-5 ml-3 mr-3 my-auto" src={bitbucket} />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! See also relevant discussion (internal).

Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (could not test because preview env not configured for BBS)

@roboquat roboquat merged commit 3f192ce into main Apr 4, 2022
@roboquat roboquat deleted the at/bbs-icon branch April 4, 2022 20:06
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a button icon on the login page for Bitbucket Server provider
4 participants