Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prebuild base selection #9109

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Apr 4, 2022

Co-authored-by: Jan Keromnes janx@gitpod.io

Description

[WIP] This change fixes the selection of the prebuild base for incremental prebuilds.

Related Issue(s)

Fixes #8980

How to test

  1. Have a repo with a .gitpod.Dockerfile.
  2. Have incremental prebuilds enabled in the Project Settings page.
  3. Push a change to the Dockerfile.
  4. Prebuilds should start and the change should be reflected in the workspace.

Release Notes

Fixes incremental prebuilds by choosing the right prebuild base.

Documentation

Co-authored-by: Jan Keromnes <janx@gitpod.io>
@jankeromnes jankeromnes force-pushed the laushinka/incremental-prebuilds-8980 branch from a802b15 to e7393b0 Compare April 4, 2022 15:36
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @laushinka for the excellent pair programming sessions today! I'm impressed how we went from "we have no idea what's going on 🤔", to "oh maybe this is not right 👀", to "this is completely broken 🙈", to "now we've made it work again 🎉".

I've tested this some more with another test repo I use for debugging prebuilds and incremental prebuilds (https://gitlab.com/jankeromnes/gitpod-staging-prebuilds -- has good details about exactly which phases ran in which order and for how long), and the base selection now works perfectly again. 🎯 That project is is our test team FYI.

Brief summary of the fix for others if interested:

  • Use await before this.isGoodBaseForIncrementalPrebuild() 🙈
  • Return true at the end of this.isGoodBaseForIncrementalPrebuild() 🙈
  • Add more debug logging 🤞

@laushinka laushinka marked this pull request as ready for review April 4, 2022 15:57
@laushinka laushinka requested a review from a team April 4, 2022 15:57
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 4, 2022
@roboquat roboquat merged commit 8ad398e into main Apr 4, 2022
@roboquat roboquat deleted the laushinka/incremental-prebuilds-8980 branch April 4, 2022 15:58
@laushinka
Copy link
Contributor Author

laushinka commented Apr 4, 2022

Many thanks @laushinka for the excellent pair programming sessions today! I'm impressed how we went from "we have no idea what's going on 🤔", to "oh maybe this is not right 👀", to "this is completely broken 🙈", to "now we've made it work again 🎉".

Thank you lots too! Exactly same feelings 😆🧡

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental prebuilds not triggering custom dockerfile rebuild on change
3 participants