-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev] Add yq v4.23.1 as yq4
binary in dev image
#9110
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM 🛹
However, when I tested how you suggested, I cannot find yq4
🤔
Also, I am curious to know what features from v4 you (or other folks?) are interested in?
Edit: I've initially approved as the change looked straight forward and correct, but I cannot find the yq4
bin, so I've temporary removed my approval. Happy to re-approve as soon as I can test :)
That's odd.
My hypothesis: Yesterday I opened the workspace without prebuild. Today, a prebuild is available. Maybe the prebuild did not use the new workspace image (that is defined in the
|
Indeed, it's the prebuild that is an incremental prebuild. I updated the prebuild with https://gitpod.io/#prebuild/https://github.com/gitpod-io/gitpod/tree/clu/yq4 and now it worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. Thx for the PR, @corneliusludmann.
Description
This PR adds
yq
in version 4.x to the dev image asyq4
binary. That allows to use the more powerfulyq
version but is still backward compatible whereyq
in version 3.x is used.How to test
Open a workspace: https://gitpod.io/#https://github.com/gitpod-io/gitpod/tree/clu/yq4
Check that
yq
in version 3.x andyq4
in version 4.x is available:Release Notes