Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Add yq v4.23.1 as yq4 binary in dev image #9110

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[dev] Add yq v4.23.1 as yq4 binary in dev image #9110

merged 1 commit into from
Apr 5, 2022

Conversation

corneliusludmann
Copy link
Contributor

Description

This PR adds yq in version 4.x to the dev image as yq4 binary. That allows to use the more powerful yq version but is still backward compatible where yq in version 3.x is used.

How to test

Open a workspace: https://gitpod.io/#https://github.com/gitpod-io/gitpod/tree/clu/yq4

Check that yq in version 3.x and yq4 in version 4.x is available:

$ yq --version
yq version 3.4.1
$ yq4 --version
yq (https://github.com/mikefarah/yq/) version 4.23.1

Release Notes

NONE

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM 🛹

However, when I tested how you suggested, I cannot find yq4 🤔

Also, I am curious to know what features from v4 you (or other folks?) are interested in?

Edit: I've initially approved as the change looked straight forward and correct, but I cannot find the yq4 bin, so I've temporary removed my approval. Happy to re-approve as soon as I can test :)

@andreafalzetti andreafalzetti self-requested a review April 4, 2022 17:23
@corneliusludmann
Copy link
Contributor Author

corneliusludmann commented Apr 5, 2022

However, when I tested how you suggested, I cannot find yq4 thinking

That's odd.

My hypothesis: Yesterday I opened the workspace without prebuild. Today, a prebuild is available. Maybe the prebuild did not use the new workspace image (that is defined in the .gitpod.yml and that's why testing it with prebuilds enabled does not work..

Also, I am curious to know what features from v4 you (or other folks?) are interested in?

  1. In some images etc. we have yq 4.x installed (e.g. in the installer image). Testing yq 4.x commands in a Gitpod workspace does not work because the CLI interface has been changed entirely.
  2. Processing multi-docs files as in post-process.sh is so much easier with yq 4.x.

@corneliusludmann
Copy link
Contributor Author

Indeed, it's the prebuild that is an incremental prebuild. I updated the prebuild with

https://gitpod.io/#prebuild/https://github.com/gitpod-io/gitpod/tree/clu/yq4

and now it worked.

@andreafalzetti

Copy link
Member

@meysholdt meysholdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Thx for the PR, @corneliusludmann.

@roboquat roboquat merged commit fc769d8 into main Apr 5, 2022
@roboquat roboquat deleted the clu/yq4 branch April 5, 2022 09:33
@roboquat roboquat added the deployed: IDE IDE change is running in production label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants