Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager-bridge] Fix counting of stale prebuild events #9129

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 5, 2022

Description

We'd count records with statusVersion = 0 stale, but this is the default value set in the DB. We want to exclude these from metrics to get an accurate count of what is actually stale.

Related Issue(s)

How to test

  1. Start prebuild
  2. No metric initially reported

Release Notes

NONE

Documentation

@easyCZ easyCZ requested a review from a team April 5, 2022 12:19
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 5, 2022
@roboquat roboquat added size/XS and removed size/M labels Apr 5, 2022
@easyCZ easyCZ force-pushed the mp/wsmb-fix-stale-counting branch from 67f69da to 7959f4f Compare April 5, 2022 13:40
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@AlexTugarev
Copy link
Member

/werft run

@roboquat roboquat merged commit 98526f4 into main Apr 5, 2022
@roboquat roboquat deleted the mp/wsmb-fix-stale-counting branch April 5, 2022 13:55
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants