[jb-gw]: disable new workspace button when url is blank #9197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
suggested changes
Apr 11, 2022
There was a problem hiding this comment.
Thanks for adding the validation, @yaohui-wyh!
Code change is clear and the button is working as described.
"New Workspace" button is enabled when the URL field is filled:
And disabled when it's empty, independently of the IDE selected:
...rains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodStartWorkspaceView.kt
Outdated
Show resolved
Hide resolved
|
Here's a suggestion for the Release Notes text on PR description:
|
Co-authored-by: Victor Nogueira <felladrin@gmail.com>
felladrin
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
All good! Thanks @yaohui-wyh!
A new Gateway Plugin version will be published soon to JetBrains Plugins Marketplace! 🚀
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
?.let) for null checksRelated Issue(s)
Clean up TODOs inside codebase
How to test
Build & Install the plugin following
https://github.com/gitpod-io/gitpod/blob/main/components/ide/jetbrains/gateway-plugin/README.md#L8
Release Notes
Documentation