Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] (optionally) surface "metadata.shortname" #9218

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Apr 11, 2022

Description

Related Issue(s)

Fixes #

How to test

Release Notes

installer: make shortname configurable

Documentation

@geropl geropl requested review from a team April 11, 2022 09:16
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels Apr 11, 2022
@geropl geropl mentioned this pull request Apr 11, 2022
53 tasks
easyCZ
easyCZ previously approved these changes Apr 11, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@geropl geropl force-pushed the gpl/installer-shortname branch from 6df6699 to 416378f Compare April 11, 2022 10:22
@roboquat roboquat added size/S and removed size/M labels Apr 11, 2022
@geropl geropl force-pushed the gpl/installer-shortname branch from 416378f to 957e11d Compare April 11, 2022 11:11
@geropl geropl force-pushed the gpl/installer-shortname branch from 957e11d to 9782fdb Compare April 11, 2022 12:57
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@geropl
Copy link
Member Author

geropl commented Apr 11, 2022

@andrew-farries Could you ✔️ ? 🙏

@roboquat roboquat merged commit 21263bd into main Apr 11, 2022
@roboquat roboquat deleted the gpl/installer-shortname branch April 11, 2022 15:33
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note size/S team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants