Enhance heuristics to delete preview-environments #9225
Conversation
fullmetalrooster
force-pushed
the
wth/impr-clean-up
branch
from
bc7ad30 to
bd08b69
Compare
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
@wulfthimm I started reviewing this but won't finish until tomorrow I'm afraid |
|
@mads-hartmann No problem. I could also walk you trough and maybe learn something on the way as I am no TS developer. |
|
@mads-hartmann Thanks for the comments. I really appreciate the insights. I will address them once I finished my current work. I expect to have them fixed over the next day. |
fullmetalrooster
force-pushed
the
wth/impr-clean-up
branch
3 times, most recently
from
6a8283a to
b7dc0ed
Compare
|
@mads-hartmann Thanks for your comments. I will make the changes on monday. |
fullmetalrooster
force-pushed
the
wth/impr-clean-up
branch
from
da1e34c to
0729a1c
Compare
|
@mads-hartmann I made the requested changes and I hope it is correct now. |
| werft.log("deleting preview", preview) | ||
| promises.push(wipePreviewEnvironmentAndNamespace(helmInstallName, preview, CORE_DEV_KUBECONFIG_PATH, { slice: `Deleting preview ${preview}` })) | ||
| }) | ||
| await Promise.all(promises) |
There was a problem hiding this comment.
I had to change the mapping as the compiler throw an arrow that .map is not supported on this set.
| @@ -6,6 +6,10 @@ import { exec } from './util/shell'; | |||
| import { previewNameFromBranchName } from './util/preview'; | |||
| import { CORE_DEV_KUBECONFIG_PATH } from './jobs/build/const'; | |||
|
|
|||
| // for testing purposes | |||
| // if set to 'true' it shows only previews that would be deleted | |||
| const DRY_RUN = true | |||
There was a problem hiding this comment.
I keep the hold label and change it to false once this PR is approved.
fullmetalrooster
force-pushed
the
wth/impr-clean-up
branch
2 times, most recently
from
aac45ed to
9367df4
Compare
|
@wulfthimm I just used this job to clean up 94 preview environments 🎉 The Werft build is failing though. Perhaps trigger a new build, maybe after rebasing on main just to be on the safe side |
fullmetalrooster
force-pushed
the
wth/impr-clean-up
branch
2 times, most recently
from
23b529b to
181daed
Compare
fullmetalrooster
force-pushed
the
wth/impr-clean-up
branch
from
181daed to
66c3336
Compare
Description
This improves the detection of outdated preview-environments. The database of each instance is tested if the last access is more than 24h ago based on the data provided by
d_b_workspace_instance.creationTime,d_b_user.creationDate,d_b_user._lastModifiedandd_b_workspace_instance_user.lastSeen. It also checks if the last commit of a branch is less than 5 days ago and deletes the preview-environment if there has been no change.Related Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/1623
How to test
Open a new workspace with this PR and run
werft run github -j .werft/platform-delete-preview-environments-cron.yaml -f. Preview environments are not deleted as the necessary function needs to be uncommented.Release Notes
Documentation