[ws-manager] Introduce workspace classes #9238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csweichel
force-pushed
the
cw/ws-class
branch
2 times, most recently
from
3170c6f to
f357539
Compare
csweichel
force-pushed
the
cw/ws-class
branch
3 times, most recently
from
3c321ae to
84e7cb5
Compare
|
/werft run 👍 started the job as gitpod-build-cw-ws-class.7 |
csweichel
force-pushed
the
cw/ws-class
branch
2 times, most recently
from
3c1dd5f to
f3b5c4a
Compare
github-actions
bot
added
team: delivery
| return xerrors.Errorf("workspace class %s: %w", name, err) | ||
| } | ||
| } | ||
|
|
||
| return err |
There was a problem hiding this comment.
Is this redundant return? Should we return nil here?
aledbf
approved these changes
Apr 28, 2022
Furisto
approved these changes
Apr 28, 2022
sagor999
approved these changes
Apr 29, 2022
Pothulapati
approved these changes
Apr 29, 2022
| @@ -58,6 +61,22 @@ type WorkspaceConfig struct { | |||
| PasswordSecret string `json:"passwordSecret"` | |||
| } `json:"redisCache"` | |||
| } `json:"registryFacade"` | |||
|
|
|||
| WorkspaceClasses map[string]WorkspaceClass `json:"classes,omitempty"` | |||
There was a problem hiding this comment.
TIOLI: Shouldn't the json field be workspaceClasses? as classes seems a bit ambiguous? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for workspace classes. Workspace classes add per-workspace support for different resource requests and limits, as well as different templates.
Related Issue(s)
works on #8261
How to test
See unit tests
Release Notes