[installer] Connect custom CA certs with wsman #9239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold for Nit otherwise lgtm |
sagor999
previously approved these changes
Apr 11, 2022
sagor999
reviewed
Apr 11, 2022
Comment on lines
121
to
123
| pod := podSpec.Containers[0] | ||
| pod.VolumeMounts = append(pod.VolumeMounts, *mnt) | ||
| podSpec.Containers[0] = pod |
There was a problem hiding this comment.
Nit:
Suggested change
| pod := podSpec.Containers[0] | |
| pod.VolumeMounts = append(pod.VolumeMounts, *mnt) | |
| podSpec.Containers[0] = pod | |
| container := podSpec.Containers[0] | |
| container.VolumeMounts = append(container.VolumeMounts, *mnt) | |
| podSpec.Containers[0] = container |
csweichel
force-pushed
the
cw/custom-ca-wsman
branch
from
9af7146 to
29849dc
Compare
|
Fixed the nit. @sagor999 please re-approve. /hold cancel |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR connects the recent introduction of custom CA certs to the installer with ws-manager.
Related Issue(s)
Fixes #9078
How to test
Release Notes