[dashboard] add notice for stable back and change latest desc #9293
Conversation
|
@gtsiolis How about use |
Sounds great, @mustard-mh! This was also the intent initially, see relevant discussion (internal) and linked review comment in #8783 (comment). |
|
Yeah, I missed it, thx @gtsiolis |
mustard-mh
force-pushed
the
hw/warning-for-stable
branch
from
63abaff to
f62fb32
Compare
|
/werft run 👍 started the job as gitpod-build-hw-warning-for-stable.2 |
|
/werft run 👍 started the job as gitpod-build-hw-warning-for-stable.3 |
|
@gtsiolis Preview environment is ok now, you can have a look. I also capture images to PR description And we have
Maybe we should file issues to solve them
|
|
Looking at this now! 👀 |
There was a problem hiding this comment.
UX changes look good, @mustard-mh! 🔮
Took me longer than expected to get back to this because lunch! 🌮 🌮 🌮 🌮 🌮
Left below some non-blocking comments for visibility and opened a follow up issue in #9326 for the overflowing dropdown mentioned in #9293 (comment) which has been bothering me for a while.
Regarding, the move of the action to stop a workspace below, I think improving this dropdown as described in #6910 could help resolve most issues one action (probably going back to dashboard) would always surface eliminating the need to click the dropdown options menu and decreasing the list of options there.
Thanks so much for noticing, @mustard-mh! 🙏 💯
| @@ -524,6 +526,19 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps, | |||
| {openLinkLabel} | |||
| </button> | |||
| </div> | |||
| {!useLatest && ( | |||
| <Alert type="info" className="mt-4 w-96"> | |||
There was a problem hiding this comment.
praise: Go w-96! Loving this width size.
| @@ -524,6 +526,19 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps, | |||
| {openLinkLabel} | |||
| </button> | |||
| </div> | |||
| {!useLatest && ( | |||
| <Alert type="info" className="mt-4 w-96"> | |||
There was a problem hiding this comment.
thought: This is out of the scope of this PR but in the future we could probably introduce better breakpoints in general within the dashboard so that a) components like this expand with the container width and b) do not need to use a fixed width attribute.
However, that's minor for now and the effort/impact of doing this sounds low, but probably something to consider when we pick up #4050 for improving the responsive layout of the dashboard. Cc @jankeromnes as we've talked about this a couple of times.
| @@ -524,6 +526,19 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps, | |||
| {openLinkLabel} | |||
| </button> | |||
| </div> | |||
| {!useLatest && ( | |||
| <Alert type="info" className="mt-4 w-96"> | |||
| You can change the default editor for opening workspaces in{" "} | |||
There was a problem hiding this comment.
thought: This alert could become obsolete or less useful so we could remove it in the future if the actions were clearer like in #6910 or more flexiible as seen in the design exploration mentioned in #8783 (comment). Re-posting the design exploration for visibility. Feedback is always welcome!
Description
add notice for stable back and change latest desc
Related Issue(s)
Fixes #
How to test
This workspace is configured with the latest release (unstable) for the editorRelease Notes
Documentation