-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make server githubApp.certSecretName configurable #9305
Conversation
@andrew-farries: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Adding hold to merge when you're ready.
/hold
@@ -107,6 +107,7 @@ type GitHubApp struct { | |||
CertPath string `json:"certPath"` | |||
MarketplaceName string `json:"marketplaceName"` | |||
LogLevel string `json:"logLevel"` | |||
CertSecretname string `json:"certSecretName"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit: CertSecretName
(upper case Name
) would fit with JSON and other Name
s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - keep hold for this nit.
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thx for adjusting!
Description
Allow the server config value
githubApp.certSecretName
to be configured via the installer config.Related Issue(s)
Follow up to #9297.
Part of the #9097 epic.
How to test
Add an experimental section to the bottom of an installer config file like this:
and invoke this installer:
In the rendered installer output the
certSecretName
will be set in theserver-config
Configmap (config.json
key).Release Notes
Documentation
No changes needed.