Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server githubApp.certSecretName configurable #9305

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Apr 13, 2022

Description

Allow the server config value githubApp.certSecretName to be configured via the installer config.

Related Issue(s)

Follow up to #9297.

Part of the #9097 epic.

How to test

Add an experimental section to the bottom of an installer config file like this:

experimental:
  webapp:
    server:
      githubApp:
        appId: 123
        authProviderId: 'someAuthProviderId'
        baseUrl: 'someBaseUrl'
        certPath: 'someCertpath'
        enabled: true
        logLevel: 'someLogLevel'
        marketplaceName: 'someMarketPlacename'
        webhookSecret: 'somewebhookSecret'
        certSecretName: 'someCertSecretName'

and invoke this installer:

installer render --config /path/to/config --use-experimental-config

In the rendered installer output the certSecretName will be set in the server-config Configmap (config.json key).

Release Notes

NONE

Documentation

No changes needed.

@andrew-farries andrew-farries requested a review from a team April 13, 2022 15:31
@roboquat
Copy link
Contributor

@andrew-farries: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

easyCZ
easyCZ previously approved these changes Apr 14, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding hold to merge when you're ready.

/hold

@@ -107,6 +107,7 @@ type GitHubApp struct {
CertPath string `json:"certPath"`
MarketplaceName string `json:"marketplaceName"`
LogLevel string `json:"logLevel"`
CertSecretname string `json:"certSecretName"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: CertSecretName (upper case Name) would fit with JSON and other Names

geropl
geropl previously approved these changes Apr 14, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - keep hold for this nit.

@andrew-farries andrew-farries dismissed stale reviews from geropl and easyCZ via 038a31f April 14, 2022 08:56
@andrew-farries
Copy link
Contributor Author

/unhold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thx for adjusting!

@roboquat roboquat merged commit 15deb83 into main Apr 14, 2022
@roboquat roboquat deleted the af/installer-server-github-config branch April 14, 2022 09:05
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants