Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker-up] Set the MTU using ceth0 value #9356

Merged
merged 3 commits into from
Apr 19, 2022
Merged

[docker-up] Set the MTU using ceth0 value #9356

merged 3 commits into from
Apr 19, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 15, 2022 •
edited
Loading

Description

The default dockerd MTU value is 1500. If the container interface value is lower than that, the behavior of the containers could end up in intermittent network behavior.

Release Notes

[docker-up] Set the MTU using ceth0 value

fixes #9354

@aledbf aledbf requested review from a team April 15, 2022 21:19
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team labels Apr 15, 2022
@aledbf aledbf changed the title [docker-up] Set same MTU than ceth0 [docker-up] Set the MTU using ceth0 value Apr 15, 2022
utam0k
utam0k reviewed Apr 15, 2022
View reviewed changes
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aledbf Looks good with nits. Please take look at my comments.

utam0k
utam0k previously approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

kylos101
kylos101 reviewed Apr 15, 2022
View reviewed changes
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question and a comment

components/docker-up/go.mod Show resolved Hide resolved
components/docker-up/docker-up/main.go Show resolved Hide resolved
@aledbf
Copy link
Member Author

aledbf commented Apr 15, 2022

The change fixes the issue with docker but docker-compose does not use the dockerd MTU value.
We need to create a document indicating the required value

networks:                                
  default:                               
    driver: bridge                       
    driver_opts:                         
      com.docker.network.driver.mtu: 1440

@aledbf
Copy link
Member Author

aledbf commented Apr 16, 2022

Fix and test for docker-compose already merged gitpod-samples/template-docker-compose#4

@shaal shaal mentioned this pull request Apr 16, 2022
Closed
@shaal shaal mentioned this pull request Apr 16, 2022
Merged
@aledbf aledbf force-pushed the aledbf/ceth0 branch 2 times, most recently from ad303d6 to ee3056c Compare April 16, 2022 17:08
csweichel
csweichel approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaal shaal mentioned this pull request Apr 16, 2022
Closed
1 task
@shaal shaal mentioned this pull request Apr 16, 2022
Merged
@roboquat roboquat merged commit 587b165 into main Apr 19, 2022
@roboquat roboquat deleted the aledbf/ceth0 branch April 19, 2022 07:50
This was referenced Apr 19, 2022
Merged
Merged
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 left review comments

@jenting jenting jenting approved these changes

@sagor999 sagor999 sagor999 approved these changes

@csweichel csweichel csweichel approved these changes

@mrsimonemms mrsimonemms mrsimonemms approved these changes

@utam0k utam0k utam0k left review comments

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production release-note size/XXL team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues accessing Fastly endpoints from within docker that runs in Gitpod
8 participants
@aledbf @mrsimonemms @kylos101 @csweichel @utam0k @sagor999 @jenting @roboquat