Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ide] Initialize a shared terminal on JetBrains IDEs when a workspace starts #9443

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[ide] Initialize a shared terminal on JetBrains IDEs when a workspace starts #9443

merged 1 commit into from
Apr 21, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Apr 21, 2022 •
edited
Loading

Description

Initialize a shared terminal on JetBrains IDEs when a workspace starts, showing a welcome message.

Related Issue(s)

This is a starting point for #8338

How to test

Screenshot 2022-04-20 at 21 44 02

Release Notes

JetBrains IDEs now start with a terminal opened, displaying an introductory message about Gitpod CLI.

Documentation

NONE

@felladrin felladrin self-assigned this Apr 21, 2022
@felladrin felladrin requested a review from a team April 21, 2022 01:12
@felladrin
Copy link
Contributor Author

@akosyakov, feel free to commit to this branch in case you have a better idea for the message displayed on the terminal.

@akosyakov akosyakov force-pushed the vn/jetbrains-terminal branch from cec497b to cb3cf41 Compare April 21, 2022 06:08
akosyakov
akosyakov approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 5c72a3a into main Apr 21, 2022
@roboquat roboquat deleted the vn/jetbrains-terminal branch April 21, 2022 06:34
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Apr 26, 2022
This was referenced Apr 26, 2022
Closed
Closed
@felladrin felladrin linked an issue Apr 26, 2022 that may be closed by this pull request
Build the tasks command API (.gitpod.yml) into JetBrains integration #6525
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees

@felladrin felladrin

Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/L team: IDE
Projects
🚀 IDE Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build the tasks command API (.gitpod.yml) into JetBrains integration
3 participants
@felladrin @akosyakov @roboquat