Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[public-api] Add kube-rbac proxy container to deployment #9481

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 22, 2022

Description

Adds kube-rbac-proxy to public-api deployment, this allows us to collect metrics using existing prometheus mechanism.

Adds an extra config to be able to choose where the metrics endpoint is on the underlying server.

Related Issue(s)

How to test

  • kubectl get po
  • Observe 2 containers in each public-api-server pod
  • Both running

Release Notes

NONE

Documentation

NONE

/hold

@easyCZ
Copy link
Member Author

easyCZ commented Apr 22, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-public-api-kube-rbac.3

@easyCZ
Copy link
Member Author

easyCZ commented Apr 22, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-mp-public-api-kube-rbac.4

@easyCZ easyCZ force-pushed the mp/public-api-kube-rbac branch from 1a7089f to 9e1fdd6 Compare April 25, 2022 07:26
@easyCZ
Copy link
Member Author

easyCZ commented Apr 25, 2022

/werft run with-vm=true with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-public-api-kube-rbac.7
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/public-api-kube-rbac branch from ed62d54 to f2aff78 Compare April 27, 2022 08:10
@roboquat roboquat added size/L and removed size/S labels Apr 27, 2022
@easyCZ easyCZ marked this pull request as ready for review April 27, 2022 11:24
@easyCZ easyCZ requested review from a team April 27, 2022 11:24
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels Apr 27, 2022
@geropl geropl marked this pull request as draft April 27, 2022 15:30
@geropl
Copy link
Member

geropl commented Apr 27, 2022

@easyCZ Please squash history before marking as "ready for review" 🙏

@easyCZ
Copy link
Member Author

easyCZ commented Apr 27, 2022

@geropl Thanks for the ping. With sticky reviews, can also be done post review :)

@easyCZ easyCZ force-pushed the mp/public-api-kube-rbac branch from 11250bd to 594b66c Compare April 27, 2022 19:01
@easyCZ easyCZ marked this pull request as ready for review April 27, 2022 19:02
@geropl
Copy link
Member

geropl commented Apr 28, 2022

With sticky reviews, can also be done post review :)

True. Still adjusting 🧘

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@roboquat roboquat merged commit 6d7e8c5 into main Apr 29, 2022
@roboquat roboquat deleted the mp/public-api-kube-rbac branch April 29, 2022 09:06
@roboquat roboquat added the deployed: webapp Meta team change is running in production label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/L team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants