-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[public-api] Add kube-rbac proxy container to deployment #9481
Conversation
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-public-api-kube-rbac.3 |
/werft run with-vm=true 👍 started the job as gitpod-build-mp-public-api-kube-rbac.4 |
1a7089f
to
9e1fdd6
Compare
/werft run with-vm=true with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-public-api-kube-rbac.7 |
ed62d54
to
f2aff78
Compare
@easyCZ Please squash history before marking as "ready for review" 🙏 |
@geropl Thanks for the ping. With sticky reviews, can also be done post review :) |
11250bd
to
594b66c
Compare
True. Still adjusting 🧘 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
Adds kube-rbac-proxy to public-api deployment, this allows us to collect metrics using existing prometheus mechanism.
Adds an extra config to be able to choose where the metrics endpoint is on the underlying server.
Related Issue(s)
How to test
kubectl get po
public-api-server
podRelease Notes
Documentation
NONE
/hold