Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prebuilds] ignore inverse PRs #9494

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[prebuilds] ignore inverse PRs #9494

merged 1 commit into from
Apr 28, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Apr 22, 2022

Description

This change ignores inverse PRs, such as they are created by pull bots.

Related Issue(s)

Fixes https://github.com/gitpod-io/security/issues/26

How to test

  • Install webhook or GH App on a repo.
  • Create a fork
  • Push to the main repo
  • Create a PR in the fork that wants to update the fork

In prod a prebuild would be created and overwrite the original prebuild from the main repo. With this change no such prebuild should be created anymore.

Release Notes

NONE
  • /werft with-vm

@svenefftinge svenefftinge requested a review from a team April 22, 2022 14:21
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 22, 2022
@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 25, 2022

/werft run

👍 started the job as gitpod-build-se-no-inverse-prs.2
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 25, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-se-no-inverse-prs.3
(with .werft/ from main)

@geropl
Copy link
Member

geropl commented Apr 25, 2022

@jankeromnes Could you take a look here as well? 🙏

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 25, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-se-no-inverse-prs.4
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 25, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-se-no-inverse-prs.5
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 25, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-se-no-inverse-prs.6
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 25, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-se-no-inverse-prs.8
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 25, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-se-no-inverse-prs.9
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 26, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-se-no-inverse-prs.10
(with .werft/ from main)

@mustard-mh
Copy link
Contributor

mustard-mh commented Apr 26, 2022

@svenefftinge run /werft with-vm=true /werft run with-vm=true will work, but you need to rebase to a9ae750 first, because this commit f5778fa is incompatible with harvester

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 26, 2022

/werft with-vm=true

👎 unknown command: with-vm=true
Use /werft help to list the available commands

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 26, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-se-no-inverse-prs.12
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

svenefftinge commented Apr 26, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-se-no-inverse-prs.13
(with .werft/ from main)

@mustard-mh
Copy link
Contributor

but you need to rebase to a9ae750 first, because this commit f5778fa is incompatible with harvester

@svenefftinge FYI, rebase via

git rebase --onto=a9ae750610a786adb8306229b123294ec44f9b6c HEAD~1

@csweichel
Copy link
Contributor

@svenefftinge can we remove the hold and get this merged?

@roboquat roboquat merged commit 028c27c into main Apr 28, 2022
@roboquat roboquat deleted the se/no-inverse-PRs branch April 28, 2022 06:46
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Apr 28, 2022
@roboquat roboquat added the deployed Change is completely running in production label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants