-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add real owner to imagebuild metadata #9511
Conversation
@@ -931,6 +931,7 @@ export class WorkspaceStarter { | |||
req.setSource(src); | |||
req.setAuth(auth); | |||
req.setForceRebuild(forceRebuild); | |||
req.setTriggeredBy(user.id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that it's not defined what the "real owner" of an image build is, exactly. Calling it "triggered by" though makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, sans the off-topic disucssion about "workspace ownership".
099c25f
to
1812981
Compare
Hey @csweichel can you approve this PR if you do not have any further concerns? |
@csweichel friendly pin so we can get this one in. 🙃 |
sorry for the delay |
Description
Add real owner to imagebuild metadata
Related Issue(s)
n.a.
How to test
Notes for reviews
The push of the imagebuild to the registry fails in the preview environment, but this also happens without my changes.
Release Notes