Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add real owner to imagebuild metadata #9511

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Add real owner to imagebuild metadata #9511

merged 1 commit into from
Apr 29, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Apr 24, 2022

Description

Add real owner to imagebuild metadata

Related Issue(s)

n.a.

How to test

Labels:       app=gitpod
              component=workspace
              gitpod.io/networkpolicy=default
              gpwsman=true
              headless=true
              metaID=db0de155-4a44-4d24-874a-f28d219dfeb1
              owner=b8a478cf-8488-44e1-a735-c155086c5095
              workspaceID=db0de155-4a44-4d24-874a-f28d219dfeb1
              workspaceType=imagebuild
  • Use gcptl imagebuilds list -> imagebuild should still be listable

Notes for reviews

The push of the imagebuild to the registry fails in the preview environment, but this also happens without my changes.

Release Notes

None

@Furisto Furisto requested review from a team April 24, 2022 22:07
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Apr 24, 2022
@geropl geropl self-assigned this Apr 25, 2022
@@ -931,6 +931,7 @@ export class WorkspaceStarter {
req.setSource(src);
req.setAuth(auth);
req.setForceRebuild(forceRebuild);
req.setTriggeredBy(user.id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that it's not defined what the "real owner" of an image build is, exactly. Calling it "triggered by" though makes sense.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, sans the off-topic disucssion about "workspace ownership".

@Furisto Furisto force-pushed the fo/imgbuild-owner branch from 099c25f to 1812981 Compare April 27, 2022 11:11
@Furisto
Copy link
Member Author

Furisto commented Apr 27, 2022

Hey @csweichel can you approve this PR if you do not have any further concerns?

@geropl
Copy link
Member

geropl commented Apr 29, 2022

@csweichel friendly pin so we can get this one in. 🙃

@csweichel
Copy link
Contributor

sorry for the delay

@roboquat roboquat merged commit c5c2bfe into main Apr 29, 2022
@roboquat roboquat deleted the fo/imgbuild-owner branch April 29, 2022 16:20
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants