[kots]: add configuration for using a custom CA certificate #9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
mrsimonemms
force-pushed
the
sje/kots-self-signed-certs
branch
from
18ca596 to
89e4263
Compare
|
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-sje-kots-self-signed-certs.2 |
mrsimonemms
force-pushed
the
sje/kots-self-signed-certs
branch
from
89e4263 to
12b6dc3
Compare
|
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-sje-kots-self-signed-certs.4 |
corneliusludmann
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Changes in this PR look good.
Tested both self-signed option as well as own self-signed generated certs with CA. All pods are running, and access to dashboard works. For k3s I needed to configure private registry. However, registry-facade has a TLS error during image build. Need to investage this further but I think it is not an issue of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for custom CA certs to the KOTS interface. There are three ways of configuring a cert with KOTS
For
1, no option is provided for a custom CA. It is assumed that this will be made against a public CA - we can keep tabs on whether there's a requirement for this in future. 🛹🛹🛹For
2, this self-signed cert is generated with the same CA used to generate the internal certs (ca-issuer-ca). This PR adds a note to explain how to extract the CA cert to import into the browser. It's expected that this will be used for limited numbers of users.For
3, this adds an optional parameter to add the CA when uploading your certs.Related Issue(s)
Fixes #8559
How to test
Deploy with KOTS. Use version
sje-kots-self-signed-certs.4indev-sjechannel (currently the most recent version in there).Release Notes
Documentation