Fix monitoring-satellite deployment #9586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-as-pyrra.5 |
fullmetalrooster
approved these changes
Apr 27, 2022
|
/hold I don't wanna block the merge queue while an unrelated build doesn't work 😓 🤦 |
|
/werft run 👍 started the job as gitpod-build-as-pyrra.6 |
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
|
/unhold a rebase solved it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArthurSens arthursens2005@gmail.com
Description
In gitpod-io/observability#115, a new component was added to monitoring-satellite. It is an optional component, so you have to explicitly say that you want this component to be rendered.
The upstream PR also made a change to the deployment script(
hack/deploy-satellite.sh). Which is supposed to be used only for development purposes in the upstream project. The problematic change is :Which will give an exit code different than 0 if the directory is empty or nonexistent. This PR just makes sure we're rendering this new component to make sure the deployment script works.
The ideal solution would be to re-implement this method to not depend on hacky upstream scripts
Related Issue(s)
None, it was reported in slack
How to test
Create a new branch from this PR and start a preview
with-vm, monitoring-satellite should be deployed successfully and should not break the job.Release Notes