-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor backups #9589
Refactor backups #9589
Conversation
c847d2f
to
a4a0296
Compare
/werft with-vm=true 👎 unknown command: with-vm=true |
/werft run with-vm=true 👍 started the job as gitpod-build-aledbf-tar.74 |
3dfad7a
to
4c02614
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works like a charm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if fullWorkspaceBackup { | ||
log.Warn("Full workspace backup is disabled.") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this means we don't support full workspace backup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full workspace backup is a feature that never reached GA. We should revise that once the PVC job is finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@aledbf This PR breaks all workspaces that use the go module because |
Description
Remove the use of
tar
and the required steps to remap files.How to test
ls -lat
, should be similar tols -lat
Release Notes