Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backups #9589

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Refactor backups #9589

merged 3 commits into from
Apr 29, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 27, 2022

Description

Remove the use of tar and the required steps to remap files.

How to test

  • Open a workspace. In the terminal execute:
touch basic
sudo touch root-file
touch executable-file
chmod +x executable-file
touch suid-file
chmod 2555 suid-file
mkdir suid-directory
chmod g+s suid-directory
  • Check the output of ls -lat, should be similar to
drwxr-x--- 8 gitpod gitpod 4096 Apr 28 17:31 .
-r-xr-sr-x 1 gitpod gitpod    0 Apr 28 17:31 suid-file
drwxr-sr-x 2 gitpod gitpod    6 Apr 28 17:31 suid-directory
-rwxr-xr-x 1 gitpod gitpod    0 Apr 28 17:30 executable-file
-rw-r--r-- 1 root   root      0 Apr 28 17:30 root-file
-rw-r--r-- 1 gitpod gitpod    0 Apr 28 17:30 basic
  • Stop and open the workspace
  • Open a terminal and run ls -lat
  • Compare the outputs

Release Notes

Refactor backups

@aledbf
Copy link
Member Author

aledbf commented Apr 28, 2022

/werft with-vm=true

👎 unknown command: with-vm=true
Use /werft help to list the available commands

@aledbf
Copy link
Member Author

aledbf commented Apr 28, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-aledbf-tar.74
(with .werft/ from main)

@roboquat roboquat added size/XXL and removed size/XL labels Apr 28, 2022
@aledbf aledbf force-pushed the aledbf/tar branch 2 times, most recently from 3dfad7a to 4c02614 Compare April 28, 2022 17:05
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team labels Apr 28, 2022
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +39 to +41
if fullWorkspaceBackup {
log.Warn("Full workspace backup is disabled.")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this means we don't support full workspace backup?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full workspace backup is a feature that never reached GA. We should revise that once the PVC job is finished.

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roboquat roboquat merged commit 7c41afe into main Apr 29, 2022
@roboquat roboquat deleted the aledbf/tar branch April 29, 2022 14:07
@mustard-mh
Copy link
Contributor

@aledbf This PR breaks all workspaces that use the go module

because go modules are stored in a strange way, their folder is read-only, This means that we can no longer write to this folder if the folder permissions are set first

image

image

@roboquat roboquat added deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note size/XXL team: delivery Issue belongs to the self-hosted team team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants