[ws-daemon] Support GIT_SSL_CAINFO #9613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csweichel
force-pushed
the
cw/fix-9604-again
branch
from
038e579 to
44baf3c
Compare
csweichel
force-pushed
the
cw/fix-9604-again
branch
from
44baf3c to
c46b10c
Compare
Pothulapati
approved these changes
Apr 28, 2022
github-actions
bot
added
team: delivery
Pothulapati
reviewed
Apr 28, 2022
| Value: mountPath, | ||
| env = []corev1.EnvVar{ | ||
| {Name: "NODE_EXTRA_CA_CERTS", Value: mountPath}, | ||
| {Name: "GIT_SSL_CAINFO", Value: mountPath}, |
There was a problem hiding this comment.
TIOLI: Should we move this to ws-daemon daemonset? As its only needed there. keeping it here means that we add it to a lot of control-plane components 🤔 ?
There was a problem hiding this comment.
it's also needed in the workspace to make the git operations work well there
geropl
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Builds, code LGTM. did not test because that's already done.
small nit about usage scope here, but seems to broaden the scope of this PR. 👍
aledbf
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes custom CA certs during content init in ws-daemon.
Much simpler than #9609
Related Issue(s)
Fixes #9604
How to test
Use with an SCM with custom CA certs
Release Notes