Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laushinka/server logs incoming 9556 #9617

Merged
merged 1 commit into from
May 2, 2022
Merged

Laushinka/server logs incoming 9556 #9617

merged 1 commit into from
May 2, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Apr 28, 2022 •
edited
Loading

Description

Implements a middleware to log incoming requests.
This is an initial PR to prep for a follow-up PR that implements an external middleware library that has what we need out of the box.

Related Issue(s)

Fixes #9556

How to test

Under /component/public-api-server run go test ./...

Release Notes

NONE

Documentation

@laushinka laushinka requested a review from easyCZ April 29, 2022 11:37
@laushinka laushinka force-pushed the laushinka/server-logs-incoming-9556 branch from 77c0af4 to 92ef834 Compare April 29, 2022 12:40
@laushinka laushinka marked this pull request as ready for review April 29, 2022 12:41
@laushinka laushinka requested a review from a team April 29, 2022 12:41
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 29, 2022
@laushinka
Copy link
Contributor Author

@easyCZ Ready for review!

easyCZ
easyCZ approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the log message change. Adding hold to leave it up to you if you change it in this PR or another.
/hold

components/public-api-server/middleware/logging.go Outdated Show resolved Hide resolved
@laushinka laushinka force-pushed the laushinka/server-logs-incoming-9556 branch 2 times, most recently from f4294d7 to 15fe1d2 Compare May 2, 2022 09:50
@laushinka laushinka force-pushed the laushinka/server-logs-incoming-9556 branch from 15fe1d2 to 33fe7c1 Compare May 2, 2022 09:51
@roboquat roboquat merged commit 10ec926 into main May 2, 2022
@roboquat roboquat deleted the laushinka/server-logs-incoming-9556 branch May 2, 2022 10:03
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server logs incoming requests and their status codes
3 participants
@laushinka @easyCZ @roboquat