Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[baseserver] Use common interceptors #9643

Merged
merged 1 commit into from
Apr 29, 2022
Merged

[baseserver] Use common interceptors #9643

merged 1 commit into from
Apr 29, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 29, 2022 •
edited
Loading

Description

  • Ensures baseserver uses common interceptors across our grpc servers

How to test

unit tests work

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ force-pushed the mp/baseserver-use-common-interceptors branch from 25a0f73 to bed31d1 Compare April 29, 2022 09:09
@easyCZ easyCZ marked this pull request as ready for review April 29, 2022 09:10
@easyCZ easyCZ requested a review from a team April 29, 2022 09:10
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 29, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Apr 29, 2022

/unhold

@roboquat roboquat merged commit 0840111 into main Apr 29, 2022
@roboquat roboquat deleted the mp/baseserver-use-common-interceptors branch April 29, 2022 10:59
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @andrew-farries @roboquat