Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link "root & docker" in Readme #9649

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Apr 29, 2022

Description

Fix dead link "root & docker" in Readme.

The second commit (intentionally left separate) applies formatting changes made by Prettier, so next time readme.md is edited, Prettier won't complain.

Related Issue(s)

Fixes #8943

How to test

  • Open readme.md from this branch.
  • Confirm if the link "root & docker" is leading to the correct page.

Release Notes

NONE

Documentation

None.

@felladrin felladrin linked an issue Apr 29, 2022 that may be closed by this pull request
@felladrin felladrin requested a review from gtsiolis April 29, 2022 11:30
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a bias for action here, @felladrin! ✨

Builds failure seems unrelated. Let's merge this.

@@ -41,7 +40,7 @@ Tightly integrated with GitLab, GitHub, and Bitbucket, Gitpod automatically and

👯‍♀️ [Collaboration](https://www.gitpod.io/docs/sharing-and-collaboration/) - invite team members to your dev environment or snapshot any state of your dev environment to share it with your team asynchronously.

🛠 Professional & customizable developer experience - a Gitpod workspace gives you the same capabilities (yes, even [root & docker](https://www.gitpod.io/docs/feature-preview/#root-access)) as your Linux machine - pre-configured and optimized for your individual development workflow. Install any [VS Code extension](https://www.gitpod.io/docs/vscode-extensions/) with one click on a user and/or team level.
🛠 Professional & customizable developer experience - a Gitpod workspace gives you the same capabilities (yes, even [root & docker](https://www.gitpod.io/docs/config-docker#configure-a-custom-dockerfile)) as your Linux machine - pre-configured and optimized for your individual development workflow. Install any [VS Code extension](https://www.gitpod.io/docs/vscode-extensions/) with one click on a user and/or team level.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for noticing, @felladrin! FWIW, the old link used to link to a dedicated page we had for inform users about an opt in to enable feature preview that enabled multiple experimental features at once, see relevant pull request.

@geropl geropl marked this pull request as draft April 29, 2022 13:31
@geropl
Copy link
Member

geropl commented Apr 29, 2022

Sorry @felladrin @gtsiolis - this PR blocked the merge queue. I will re-trigger the build w/o preview env:

/werft run no-preview=true

👍 started the job as gitpod-build-vn-8943-dead-link-in-readme.3
(with .werft/ from main)

@felladrin felladrin force-pushed the vn/8943-dead-link-in-readme branch from b070b2d to 0309830 Compare April 29, 2022 14:23
@felladrin felladrin marked this pull request as ready for review April 29, 2022 15:03
@roboquat roboquat merged commit 269164f into main Apr 29, 2022
@roboquat roboquat deleted the vn/8943-dead-link-in-readme branch April 29, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead link in Readme
4 participants