Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Use local workspace clusters only in full installs #9657

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Apr 29, 2022

Description

Register a local cluster ws-manager only when we actually deploy one, ie when we are doing a full self hosted installation rather than a SaaS install to gitpod.io.

Related Issue(s)

Part of #9097

How to test

Release Notes

NONE

Documentation

none

@andrew-farries andrew-farries force-pushed the af/local-ws-manager-only-in-full-installations branch from 0688330 to f7e6db3 Compare April 29, 2022 16:08
@andrew-farries andrew-farries changed the title Use local workspace clusters only in full installs [installer] Use local workspace clusters only in full installs Apr 29, 2022
@andrew-farries andrew-farries marked this pull request as ready for review April 29, 2022 16:11
@andrew-farries andrew-farries requested a review from a team April 29, 2022 16:11
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 29, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @andrew-farries for reading my lengthy ramblings and turning that into a 3-lines PR 😆

@roboquat roboquat merged commit bab1524 into main Apr 29, 2022
@roboquat roboquat deleted the af/local-ws-manager-only-in-full-installations branch April 29, 2022 16:23
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants